feat: add ArrowClientExt::insert_arrow_with()#436
Open
abonander wants to merge 1 commit into
Open
Conversation
abonander
requested review from
joe-clickhouse,
kavirajk and
peter-leonov-ch
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
abonander
force-pushed
the
ab/insert-arrow-with
branch
from
a378a38 to
335f375
Compare
| let insert = client | ||
| .insert_formatted_with(sql) | ||
| // Prevent ClickHouse from double-compressing | ||
| .with_setting("output_format_arrow_compression_method", "none") |
There was a problem hiding this comment.
Think this'll be a no-op for inserts? Any double compression concerns on insert would be in the transport-level on top of Arrow. Also, that same 5 line method chain is repeated twice, only diff seems to be where the sql comes from. Possible op to factor it out...not a big deal though.
joe-clickhouse
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ArrowClientExt::insert_arrow_with()taking a raw SQL statement which will be useful in the ADBC driver as we'll need to synthesize our own to support the various ingest modes.Checklist
Delete items not relevant to your PR: